Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition with Deriving vault tokens #2275

Merged
merged 2 commits into from
Feb 2, 2017
Merged

Fix race condition with Deriving vault tokens #2275

merged 2 commits into from
Feb 2, 2017

Commits on Feb 2, 2017

  1. Fix race condition with Deriving vault tokens 

    This PR fixes a race condition in which the client was not locked while
deriving Vault tokens. This allowed the token to be set which would
cause subsequent Vault requests to fail with permission denied because
the incorrect Vault token was being used.

Further this PR makes the unsetting and unlocking of the client atomic
to avoid an even harder to hit race condition (not sure it was ever hit
but was still incorrect).
    @dadgar
    dadgar committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    9e822a2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into b-vault-race

    @dadgar
    dadgar committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    4bf2401 View commit details
    Browse the repository at this point in the history