Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two issues during client restore state #2376

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Fix two issues during client restore state #2376

merged 1 commit into from
Feb 28, 2017

Commits on Feb 28, 2017

  1. Fix two issues during client restore state 

    This PR fixes two issues:

1) A close of a nil stopCollection channel when restoring and prestart
fails. The failure will cause the killCh to be triggered which will
close collection before it has been initialized.

2) Fixes a deadlock in which the handleWaitCh is never triggered since
it is not initialized when there is an error in prestart and the killCh
is triggered.

Both fixes are by maintaining the loop invariant that the two channels
are valid after there is a handle.
    @dadgar
    dadgar committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    4826d84 View commit details
    Browse the repository at this point in the history