Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't exec uname for node attribute kernel.version #2380

Merged
merged 2 commits into from
Mar 1, 2017
Merged

Don't exec uname for node attribute kernel.version #2380

merged 2 commits into from
Mar 1, 2017

Commits on Mar 1, 2017

  1. Don't exec uname for node attribute kernel.version 

    Previously with client fingerprinting, sys/exec's Command
function was being used to execute `uname -r` and the return
string processed into the kernel.version node attribute.

This change uses gopsutil/host KernelVersion function
instead.  This means we can drop the os/exec, strings and
fmt imports... and not execute an external binary.

Signed-off-by: Dave Walker (Daviey) <email@daviey.com>
    @Daviey
    Daviey committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    5875bc1 View commit details
    Browse the repository at this point in the history

  2. Enable kernel.version on Windows 

    Previously, this value was guarded against running on Windows
because it called the `uname` command which is unlikely to
be there.

This change now sets the value from gopsutil, which might
well be an empty string.

Signed-off-by: Dave Walker (Daviey) <email@daviey.com>
    @Daviey
    Daviey committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    5d484dc View commit details
    Browse the repository at this point in the history