Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Consul Syncer into new ServiceClient #2467

Merged
merged 38 commits into from
Apr 19, 2017
Merged

Refactor Consul Syncer into new ServiceClient #2467

merged 38 commits into from
Apr 19, 2017

Commits on Apr 19, 2017

  1. Refactor Consul Syncer into new ServiceClient 

    Fixes #2478 #2474 #1995 #2294

The new client only handles agent and task service advertisement. Server
discovery is mostly unchanged.

The Nomad client agent now handles all Consul operations instead of the
executor handling task related operations. When upgrading from an
earlier version of Nomad existing executors will be told to deregister
from Consul so that the Nomad agent can re-register the task's services
and checks.

Drivers - other than qemu - now support an Exec method for executing
abritrary commands in a task's environment. This is used to implement
script checks.

Interfaces are used extensively to avoid interacting with Consul in
tests that don't assert any Consul related behavior.
    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    10cb924 View commit details
    Browse the repository at this point in the history

  2. Remove unused syncInterval

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    e13b149 View commit details
    Browse the repository at this point in the history

  3. Remove some lies

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    7930d35 View commit details
    Browse the repository at this point in the history

  4. Add UpdateTask method instead of Remove/Add

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    b693791 View commit details
    Browse the repository at this point in the history

  5. Switch ServiceClient to synchronizing state 

    Previously it applied a stream of operations. Reconciling state is less
complex and error prone at the cost of slightly higher CPU/memory usage.
    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    80882f3 View commit details
    Browse the repository at this point in the history

  6. Fix shutdown when consul is down

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    b4e40ef View commit details
    Browse the repository at this point in the history

  7. Move ScriptExecutor to driver

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    63a8307 View commit details
    Browse the repository at this point in the history

  8. Fix comment to reflect reality

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    a3fc76b View commit details
    Browse the repository at this point in the history

  9. Move removal from Consul into TaskRunner cleanup

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    fd69d48 View commit details
    Browse the repository at this point in the history

  10. Explain cleanup defer in test

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    b4c7d92 View commit details
    Browse the repository at this point in the history

  11. Add comments, clarify names, fix PR comments

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    4002d87 View commit details
    Browse the repository at this point in the history

  12. Use a DriverAbility to expose Exec functionality

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    0e0845e View commit details
    Browse the repository at this point in the history

  13. Use nifty testtask sleep command for xplat compat

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    7ac9215 View commit details
    Browse the repository at this point in the history

  14. Stop being lazy and just type out struct{}{}

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    80617a9 View commit details
    Browse the repository at this point in the history

  15. Plumb alloc id + task name into script check logs

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    48269c3 View commit details
    Browse the repository at this point in the history

  16. Explain PortLabel handling in RegisterAgent

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    5d75efc View commit details
    Browse the repository at this point in the history

  17. Backoff on Consul lookup failures

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    6bb7d8b View commit details
    Browse the repository at this point in the history

  18. Fix circular test imports

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    db8aabe View commit details
    Browse the repository at this point in the history

  19. Remove stale comment

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    4f22413 View commit details
    Browse the repository at this point in the history

  20. Remove commits return value 

    ...and still protect against leaking agent entries in Consul on
shutdown.
    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    7de3ada View commit details
    Browse the repository at this point in the history

  21. Rework to account for ports not being in IDs 

    Previous implementation assumed all struct fields were included in
service and check IDs. Service IDs never include port labels and check
IDs *optionally* include port labels, so lots of things had to change.

Added a really big test to exercise this.
    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    927b265 View commit details
    Browse the repository at this point in the history

  22. Follow _testing.go convention for testing tools

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    6a56b0e View commit details
    Browse the repository at this point in the history

  23. Test script check exit codes

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    465cc51 View commit details
    Browse the repository at this point in the history

  24. Always fail script checks when deadline exceeded

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    d3f3af8 View commit details
    Browse the repository at this point in the history

  25. Metricsify new Consul client

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    de3d783 View commit details
    Browse the repository at this point in the history

  26. Explain weird timer logic

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    f0bec63 View commit details
    Browse the repository at this point in the history

  27. Unregister from Consul when waiting for restart

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    8e0c97e View commit details
    Browse the repository at this point in the history

  28. Only register HTTPS agent check when Consul>=0.7.2 

    Support for TLSSkipVerify in other checks coming soon!
    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    3468383 View commit details
    Browse the repository at this point in the history

  29. Forgot an important word

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    5948daf View commit details
    Browse the repository at this point in the history

  30. Use spiffy new Go 1.8 subtest feature

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    6d9e61b View commit details
    Browse the repository at this point in the history

  31. Use go-version instead of manual version parsing

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    64057d4 View commit details
    Browse the repository at this point in the history

  32. Fix diff test + bonus upgrade to subtests

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    86bc2fb View commit details
    Browse the repository at this point in the history

  33. Add TLSSkipVerify support to api and parser

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    7c67166 View commit details
    Browse the repository at this point in the history

  34. Skip checks with TLSSkipVerify if it's unsupported 

    Fixes #2218
    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    4cf34ed View commit details
    Browse the repository at this point in the history

  35. Document tls_skip_verify

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    a5dcf6b View commit details
    Browse the repository at this point in the history

  36. Thanks go vet!

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    b9ea276 View commit details
    Browse the repository at this point in the history

  37. Fix Windows build.

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    fb3b30b View commit details
    Browse the repository at this point in the history

  38. Fix consul test build on Windows

    @schmichael
    schmichael committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    58430bf View commit details
    Browse the repository at this point in the history