-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Consul Syncer into new ServiceClient #2467
Merged
Merged
Commits on Apr 19, 2017
-
Refactor Consul Syncer into new ServiceClient
Fixes #2478 #2474 #1995 #2294 The new client only handles agent and task service advertisement. Server discovery is mostly unchanged. The Nomad client agent now handles all Consul operations instead of the executor handling task related operations. When upgrading from an earlier version of Nomad existing executors will be told to deregister from Consul so that the Nomad agent can re-register the task's services and checks. Drivers - other than qemu - now support an Exec method for executing abritrary commands in a task's environment. This is used to implement script checks. Interfaces are used extensively to avoid interacting with Consul in tests that don't assert any Consul related behavior.
Configuration menu - View commit details
-
Copy full SHA for 10cb924 - Browse repository at this point
Copy the full SHA 10cb924View commit details -
Configuration menu - View commit details
-
Copy full SHA for e13b149 - Browse repository at this point
Copy the full SHA e13b149View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7930d35 - Browse repository at this point
Copy the full SHA 7930d35View commit details -
Configuration menu - View commit details
-
Copy full SHA for b693791 - Browse repository at this point
Copy the full SHA b693791View commit details -
Switch ServiceClient to synchronizing state
Previously it applied a stream of operations. Reconciling state is less complex and error prone at the cost of slightly higher CPU/memory usage.
Configuration menu - View commit details
-
Copy full SHA for 80882f3 - Browse repository at this point
Copy the full SHA 80882f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4e40ef - Browse repository at this point
Copy the full SHA b4e40efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63a8307 - Browse repository at this point
Copy the full SHA 63a8307View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3fc76b - Browse repository at this point
Copy the full SHA a3fc76bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd69d48 - Browse repository at this point
Copy the full SHA fd69d48View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4c7d92 - Browse repository at this point
Copy the full SHA b4c7d92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4002d87 - Browse repository at this point
Copy the full SHA 4002d87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e0845e - Browse repository at this point
Copy the full SHA 0e0845eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ac9215 - Browse repository at this point
Copy the full SHA 7ac9215View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80617a9 - Browse repository at this point
Copy the full SHA 80617a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48269c3 - Browse repository at this point
Copy the full SHA 48269c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d75efc - Browse repository at this point
Copy the full SHA 5d75efcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bb7d8b - Browse repository at this point
Copy the full SHA 6bb7d8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for db8aabe - Browse repository at this point
Copy the full SHA db8aabeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f22413 - Browse repository at this point
Copy the full SHA 4f22413View commit details -
...and still protect against leaking agent entries in Consul on shutdown.
Configuration menu - View commit details
-
Copy full SHA for 7de3ada - Browse repository at this point
Copy the full SHA 7de3adaView commit details -
Rework to account for ports not being in IDs
Previous implementation assumed all struct fields were included in service and check IDs. Service IDs never include port labels and check IDs *optionally* include port labels, so lots of things had to change. Added a really big test to exercise this.
Configuration menu - View commit details
-
Copy full SHA for 927b265 - Browse repository at this point
Copy the full SHA 927b265View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a56b0e - Browse repository at this point
Copy the full SHA 6a56b0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 465cc51 - Browse repository at this point
Copy the full SHA 465cc51View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3f3af8 - Browse repository at this point
Copy the full SHA d3f3af8View commit details -
Configuration menu - View commit details
-
Copy full SHA for de3d783 - Browse repository at this point
Copy the full SHA de3d783View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0bec63 - Browse repository at this point
Copy the full SHA f0bec63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e0c97e - Browse repository at this point
Copy the full SHA 8e0c97eView commit details -
Only register HTTPS agent check when Consul>=0.7.2
Support for TLSSkipVerify in other checks coming soon!
Configuration menu - View commit details
-
Copy full SHA for 3468383 - Browse repository at this point
Copy the full SHA 3468383View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5948daf - Browse repository at this point
Copy the full SHA 5948dafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d9e61b - Browse repository at this point
Copy the full SHA 6d9e61bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64057d4 - Browse repository at this point
Copy the full SHA 64057d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86bc2fb - Browse repository at this point
Copy the full SHA 86bc2fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c67166 - Browse repository at this point
Copy the full SHA 7c67166View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cf34ed - Browse repository at this point
Copy the full SHA 4cf34edView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5dcf6b - Browse repository at this point
Copy the full SHA a5dcf6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9ea276 - Browse repository at this point
Copy the full SHA b9ea276View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb3b30b - Browse repository at this point
Copy the full SHA fb3b30bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58430bf - Browse repository at this point
Copy the full SHA 58430bfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.