Improve artifact download error message #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2289 Unfortunately took more RecoverableError hijinx than I would have liked. There might be a better way.
dadgar
approved these changes
Mar 26, 2017
client/task_runner.go
Outdated
| if rerr, ok := err.(*structs.RecoverableError); ok { | ||
| return structs.NewRecoverableError(wrapped, rerr.Recoverable) | ||
| if rerr, ok := err.(structs.Recoverable); ok { | ||
| return structs.NewRecoverableError(wrapped, rerr.Recoverable()) |
There was a problem hiding this comment.
return structs.NewRecoverableError(wrapped, structs.IsRecoverable(err))?
There was a problem hiding this comment.
Everywhere this pattern is used
There was a problem hiding this comment.
It honestly might be worth adding a helper function.
func NewWrappedRecoverableError(wrapped, original) { ... }
It just checks if the original is recoverable.
schmichael
force-pushed
the
f-2289-better-artifact-err
branch
from
0e80e7c
to
a1e24d9
Compare
schmichael
force-pushed
the
f-2289-better-artifact-err
branch
from
a1e24d9
to
ae9d495
Compare
schmichael
added a commit
that referenced
this pull request
Mar 28, 2017
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2289
Unfortunately took more RecoverableError hijinx than I would have liked.
There might be a better way.