Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env vars for dc, region #2507

Merged
merged 12 commits into from
May 4, 2017
Merged

Add env vars for dc, region #2507

merged 12 commits into from
May 4, 2017

Commits on May 3, 2017

  1. starting the jelly bean trail for two new env vars

    @qkate @dadgar
    qkate authored and dadgar committed May 3, 2017
    Configuration menu
    Copy the full SHA
    cf1b298 View commit details
    Browse the repository at this point in the history

  2. add dc and region to task env building function. flipped order of a c… 

    …ouple functions to be consistent with the ordering of the rest of that section.
    @qkate @dadgar
    qkate authored and dadgar committed May 3, 2017
    Configuration menu
    Copy the full SHA
    aeec7b3 View commit details
    Browse the repository at this point in the history

  3. add helper functions to set and clear dc, region names.

    @qkate @dadgar
    qkate authored and dadgar committed May 3, 2017
    Configuration menu
    Copy the full SHA
    a5c4663 View commit details
    Browse the repository at this point in the history

  4. just found out dc and region are going to be a bit different, as Regi… 

    …on didn't previously exist in the Node struct.
    @qkate @dadgar
    qkate authored and dadgar committed May 3, 2017
    Configuration menu
    Copy the full SHA
    d10bfb4 View commit details
    Browse the repository at this point in the history

  5. allow region to also be interpolated, like datacenter.

    @qkate @dadgar
    qkate authored and dadgar committed May 3, 2017
    Configuration menu
    Copy the full SHA
    530cf03 View commit details
    Browse the repository at this point in the history

  6. I think I did it.

    @qkate @dadgar
    qkate authored and dadgar committed May 3, 2017
    Configuration menu
    Copy the full SHA
    4a4417d View commit details
    Browse the repository at this point in the history

  7. mention the two newly available env vars in the docs.

    @qkate @dadgar
    qkate authored and dadgar committed May 3, 2017
    Configuration menu
    Copy the full SHA
    9eac667 View commit details
    Browse the repository at this point in the history

  8. remove periods from things that aren't sentences.

    @qkate @dadgar
    qkate authored and dadgar committed May 3, 2017
    Configuration menu
    Copy the full SHA
    4a4e48c View commit details
    Browse the repository at this point in the history

  9. responding to feedback on PR: remove Region from Node struct, some gr… 

    …ammatical niceties.
    @qkate @dadgar
    qkate authored and dadgar committed May 3, 2017
    Configuration menu
    Copy the full SHA
    6ea156b View commit details
    Browse the repository at this point in the history

  10. important word change in docs.

    @qkate @dadgar
    qkate authored and dadgar committed May 3, 2017
    Configuration menu
    Copy the full SHA
    0c293d2 View commit details
    Browse the repository at this point in the history

  11. fix test.

    @qkate @dadgar
    qkate authored and dadgar committed May 3, 2017
    Configuration menu
    Copy the full SHA
    82d60ce View commit details
    Browse the repository at this point in the history

  12. Fix tests

    @dadgar
    dadgar committed May 3, 2017
    Configuration menu
    Copy the full SHA
    3642434 View commit details
    Browse the repository at this point in the history