Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up consul earlier when destroying a task #2596

Merged
merged 2 commits into from
May 2, 2017
Merged

Clean up consul earlier when destroying a task #2596

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06f3aac
clean up consul earlier when destroying a task
weargoggles Apr 27, 2017
aa2da9e
address feedback
Apr 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions client/task_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,6 +1031,10 @@ func (r *TaskRunner) run() {
return
}

// Remove from consul before killing the task so that traffic
// can be rerouted
r.consul.RemoveTask(r.alloc.ID, r.task)

// Store the task event that provides context on the task
// destroy. The Killed event is set from the alloc_runner and
// doesn't add detail
Expand Down