Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor blocking/migrating allocations #3007

Merged
merged 12 commits into from
Aug 15, 2017
Merged

Refactor blocking/migrating allocations #3007

merged 12 commits into from
Aug 15, 2017

Commits on Aug 11, 2017

  1. Only set alloc status if it's not already terminal

    @schmichael
    schmichael committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    de15046 View commit details
    Browse the repository at this point in the history

  2. initial attempt at refactoring blocked/migrating

    @schmichael
    schmichael committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    0f584a0 View commit details
    Browse the repository at this point in the history

  3. switch from alloc blocker to new interface 

    interface has 3 implementations:

1. local for blocking and moving data locally
2. remote for blocking and moving data from another node
3. noop for allocs that don't need to block
    @schmichael
    schmichael committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    8c18119 View commit details
    Browse the repository at this point in the history

  4. Set failed status instead of panic'ing 

    Fixup some TODOs and formatting left from new prevAllocWatcher code.
    @schmichael
    schmichael committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    113d8e3 View commit details
    Browse the repository at this point in the history

  5. Update tests for new blocking/migrating code

    @schmichael
    schmichael committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    8253439 View commit details
    Browse the repository at this point in the history

  6. Exit if alloc listener closes 

    Add test for that case, add comments, remove debug logging
    @schmichael
    schmichael committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    4f7c5e6 View commit details
    Browse the repository at this point in the history

  7. Soft fail on migration errors

    @schmichael
    schmichael committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    537d0e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2017

  1. Move migrating state into prevAllocWatcher

    @schmichael
    schmichael committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    85b9dd9 View commit details
    Browse the repository at this point in the history

  2. Return move errors from local Migrate like remote 

    Since alloc runner just logs these errors and continues there's no
reason not to return it.
    @schmichael
    schmichael committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    ce4b919 View commit details
    Browse the repository at this point in the history

  3. spelling

    @schmichael
    schmichael committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    8983bc0 View commit details
    Browse the repository at this point in the history

  4. Cleanup comments and return val

    @schmichael
    schmichael committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    d55b4c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2017

  1. Fix formatting

    @schmichael
    schmichael committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    44b6988 View commit details
    Browse the repository at this point in the history