Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node access is done using locked Node copy #3461

Merged
merged 3 commits into from
Oct 30, 2017
Merged

Node access is done using locked Node copy #3461

merged 3 commits into from
Oct 30, 2017

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Oct 27, 2017

Fixes #3454

Reliably reproduced the data race before by having a fingerprinter
change the nodes attributes every millisecond and syncing at the same
rate. With fix, did not ever panic. Further, running before and after with race
detector shows the data race is gone.

Fixes #3454

Reliably reproduced the data race before by having a fingerprinter
change the nodes attributes every millisecond and syncing at the same
rate. With fix, did not ever panic.
@@ -501,7 +501,7 @@ func (c *Client) CollectAllAllocs() error {
func (c *Client) Node() *structs.Node {
c.configLock.RLock()
defer c.configLock.RUnlock()
return c.config.Node
return c.configCopy.Node
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other public methods in this file that access fields from config rather than configcopy. - datacenter/region/nodeid etc. None of them are maps, but are other lurking races there as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those fields are immutable once the Client is returned, the mutable fields are the attributes and links, which surfaced via the Node() and Fingerprint() using the same Node object rather than the readonly copy.

@dadgar dadgar merged commit 2d77197 into master Oct 30, 2017
@dadgar dadgar deleted the b-node-race branch October 30, 2017 19:35
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrent map iteration and map write
2 participants