-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task route hierarchy in the UI #3472
Conversation
|
||
model({ name }) { | ||
const allocation = this.modelFor('allocations.allocation'); | ||
if (allocation) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If allocation is falsey, the allocation route model hook will set the application error state.
export default Controller.extend({ | ||
network: computed.alias('model.resources.networks.firstObject'), | ||
ports: computed('network.reservedPorts.[]', 'network.dynamicPorts.[]', function() { | ||
const ports = this.get('network.reservedPorts') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can probably just return here
<div class="boxed-section is-small"> | ||
<div class="boxed-section-body inline-definitions"> | ||
<span class="label">Task Details</span> | ||
<span class="pair"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can try dl/dd here instead of .pair
, if that makes the css any easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. It would certainly be semantically better.
@@ -105,83 +111,17 @@ test('each task row should list high-level information for the task', function(a | |||
); | |||
|
|||
assert.ok(reservedPorts.length, 'The task has reserved ports'); | |||
assert.ok(dynamicPorts.length, 'The task has reserved ports'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"reserved" -> "dynamic"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but looks cool otherwise.
Drilling into a task from an allocation transitions to the task heirarchy.
Now that there is a task detail page, some of the content from the allocation detail page is better suited there.
6aa93c8
to
b3dc736
Compare
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Making room for logs and file browsing.
Updated allocation detail page:
![image](https://user-images.githubusercontent.com/174740/32207001-2f463f8e-bdb6-11e7-9fb5-92cc6dbb8c86.png)
New task overview page:
![image](https://user-images.githubusercontent.com/174740/32207012-4210a708-bdb6-11e7-9795-7d6042642441.png)