-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nomad agent reload TLS configuration on SIGHUP #3479
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
25a86ac
Allow server TLS configuration to be reloaded via SIGHUP
chelseakomlo c65e23b
dynamic tls reloading for nomad agents
chelseakomlo c9acc5f
code cleanup and refactoring
chelseakomlo 256f5a0
ensure keyloader is initialized, add comments
chelseakomlo cbd18ae
allow downgrading from TLS
chelseakomlo 50a1336
initalize keyloader if necessary
chelseakomlo ff1d0dd
integration test for tls reload
chelseakomlo d7ff9f4
fix up test to assert success on reloaded TLS configuration
chelseakomlo 0be15b0
failure in loading a new TLS config should remain at current
chelseakomlo 0c4336e
reload agent configuration before specific server/client
chelseakomlo 2990eb8
introduce a get-or-set method for keyloader
chelseakomlo b2ef194
fixups from code review
chelseakomlo fea24fe
fix up linting errors
chelseakomlo a40aafb
fixups from code review
chelseakomlo 2cade96
add lock for config updates; improve copy of tls config
chelseakomlo 12cb657
GetCertificate only reloads certificates dynamically for the server
chelseakomlo 885c175
config updates/copies should be on agent
chelseakomlo d46eb3b
improve http integration test
chelseakomlo 3c7bb25
simplify agent reloading storing a local copy of config
dadgar ae63199
reuse the same keyloader when reloading
dadgar d7d25b4
Test that server and client get reloaded but keep keyloader
dadgar 9f954dc
Keyloader exposes GetClientCertificate as well for outgoing connections
dadgar 98d6358
Fix spelling
dadgar 75a0c60
correct changelog style
dadgar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this named import necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are automatically added from https://godoc.org/golang.org/x/tools/cmd/goimports