Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes auto reverts robust against previously stable job that fail to start correctly upon reverting #3496

Merged
merged 8 commits into from
Nov 3, 2017
Merged

Makes auto reverts robust against previously stable job that fail to start correctly upon reverting #3496

merged 8 commits into from
Nov 3, 2017

Commits on Nov 3, 2017

  1. Fixes auto revert to check if the job's spec has changed before rever… 

    …ting. This prevents infinite reverting when reverting to a job version that was previously stable, but not so after attempting a revert.
    @preetapan
    preetapan committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    f83c540 View commit details
    Browse the repository at this point in the history

  2. Update rollback test to add a spec change, and add new test for rollb… 

    …ack failed status
    @preetapan
    preetapan committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    99c57ee View commit details
    Browse the repository at this point in the history

  3. Remove extra newline

    @preetapan
    preetapan committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    48844e0 View commit details
    Browse the repository at this point in the history

  4. Clarify comment about infinite revert cycles

    @preetapan
    preetapan committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    ba6c808 View commit details
    Browse the repository at this point in the history

  5. Adds SpecChanged check to alloc health and fail deployment end points… 

    …, and other code review comments.
    @preetapan
    preetapan committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    145a959 View commit details
    Browse the repository at this point in the history

  6. Check that job version doesn't change when rollback does not occur du… 

    …e to identical spec
    @preetapan
    preetapan committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    05af7bd View commit details
    Browse the repository at this point in the history

  7. Added more unit tests for testing rollback when job has identical spe… 

    …c to AllocHealth and DeploymentStatus endpoints.
    @preetapan
    preetapan committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    f92e564 View commit details
    Browse the repository at this point in the history

  8. Adds comment to handleRollbackValidity method and other small test re… 

    …adability fixes.
    @preetapan
    preetapan committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    04feeef View commit details
    Browse the repository at this point in the history