Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle leader task being dead in RestoreState #3502

Merged
merged 1 commit into from
Nov 15, 2017

Commits on Nov 15, 2017

  1. Handle leader task being dead in RestoreState

    Fixes the panic mentioned in
    #3420 (comment)
    
    While a leader task dying serially stops all follower tasks, the
    synchronizing of state is asynchrnous. Nomad can shutdown before all
    follower tasks have updated their state to dead thus saving the state
    necessary to hit this panic: *have a non-terminal alloc with a dead
    leader.*
    
    The actual fix is a simple nil check to not assume non-terminal allocs
    leader's have a TaskRunner.
    schmichael committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    0de0e1d View commit details
    Browse the repository at this point in the history