Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory default is 10, not 300 #3520

Merged
merged 5 commits into from
Nov 10, 2017
Merged

memory default is 10, not 300 #3520

merged 5 commits into from
Nov 10, 2017

Commits on Nov 7, 2017

  1. memory default is 10, not 300

    Verified by creating sample job and removing memory from resources
    
    ```
    Task "redis" is "running"
    Task Resources
    CPU        Memory          Disk     IOPS  Addresses
    3/100 MHz  976 KiB/10 MiB  300 MiB  0     db: **.**.**.**:20824
    ```
    angrycub committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    264d999 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7c98e46 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2017

  1. Canonicalize task and remove merge with MinResources

    The current code would merge the job with the output of MinResources causing the nil to be replaced with MemoryMB=helper.IntToPtr(10).  When later `Canonicalize`d, the 10 would cause the default of 300 not to be applied. Running `Canonicalize` on the task itself guarantees that CPU, MemoryMB, and IOPS is set, so we can remove the Merge withMinResources.
    angrycub committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    1cb5286 View commit details
    Browse the repository at this point in the history
  2. Adopted pattern from LogConfig to handle panic when no resource stanz…

    …a at all
    
    In testing realized that Resources night not be present at all.  Testing this case caused panic. Added in a means to collect clean defaults in that case.
    angrycub committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    20ea6b2 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2017

  1. Configuration menu
    Copy the full SHA
    892f348 View commit details
    Browse the repository at this point in the history