Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serf timeouts #354

Closed
wants to merge 2 commits into from
Closed

Serf timeouts #354

wants to merge 2 commits into from

Conversation

gregory-m
Copy link
Contributor

Implanted serf reconnect and tombstone timeouts configuration.

Close #333

@dadgar
Copy link
Contributor

dadgar commented Oct 28, 2015

Hey, I apologize for not looking into more detail when you filed the bug but I don't think we need to adjust anything in the serf layer. I think you instead want to expose these as Server configs:

nomad/nomad/config.go

Lines 127 to 139 in 7ab84c2

// EvalGCInterval is how often we dispatch a job to GC evaluations
EvalGCInterval time.Duration
// EvalGCThreshold is how "old" an evaluation must be to be eligible
// for GC. This gives users some time to debug a failed evaluation.
EvalGCThreshold time.Duration
// NodeGCInterval is how often we dispatch a job to GC failed nodes.
NodeGCInterval time.Duration
// NodeGCThreshold is how "old" a nodemust be to be eligible
// for GC. This gives users some time to view and debug a failed nodes.
NodeGCThreshold time.Duration
.

You can see how the Core scheduler uses these to GC nodes:

nomad/nomad/core_sched.go

Lines 131 to 132 in 7ab84c2

cutoff := time.Now().UTC().Add(-1 * c.srv.config.NodeGCThreshold)
oldThreshold := tt.NearestIndex(cutoff)
.

I think we can either close this PR or modify it to expose the above instead.

@gregory-m
Copy link
Contributor Author

No problem. I will open another pull request.

@gregory-m gregory-m closed this Oct 28, 2015
@dadgar
Copy link
Contributor

dadgar commented Oct 28, 2015

Thanks!

benbuzbee pushed a commit to benbuzbee/nomad that referenced this pull request Jul 21, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants