-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase and merge of docker sysctl support #3568
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
84a0894
feat(docker driver): adds sysctls and ulimits configs
samber cf58699
test(docker driver): testing sysctls and ulimits
samber d15f01d
:lipstick:
samber db2b09e
doc(docker driver): Adds doc for ulimit and sysctl
samber 657619c
Oops
samber e6c0372
review(docker driver): sysctls -> sysctl + ulimits -> ulimit
samber 48829e8
Fix test compilation after rebase
preetapan 9e07471
Fix gofmt warnings
preetapan bc08d31
Remove merge conflict marker from documentation
preetapan 0d47977
Address some review comments
preetapan ee4b4d8
Better error validation, and added test case for invalid sysctl inputs
preetapan d522149
Missed assert in one place
preetapan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,7 +74,7 @@ The `docker` driver supports the following configuration in the job spec. Only | |
command = "my-command" | ||
} | ||
``` | ||
|
||
* `dns_search_domains` - (Optional) A list of DNS search domains for the container | ||
to use. | ||
|
||
|
@@ -97,6 +97,34 @@ The `docker` driver supports the following configuration in the job spec. Only | |
* `interactive` - (Optional) `true` or `false` (default). Keep STDIN open on | ||
the container. | ||
|
||
* `sysctl` - (Optional) A key-value map of sysctl configurations to set to the | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This sentence is incomplete. |
||
containers on start. | ||
|
||
```hcl | ||
config { | ||
sysctl { | ||
net.core.somaxconn = "16384" | ||
} | ||
} | ||
``` | ||
|
||
* `ulimit` - (Optional) A key-value map of ulimit configurations to set to the | ||
containers on start. | ||
|
||
```hcl | ||
config { | ||
ulimit { | ||
nproc = "4242" | ||
nofile = "2048:4096" | ||
} | ||
} | ||
``` | ||
|
||
* `privileged` - (Optional) `true` or `false` (default). Privileged mode gives | ||
the container access to devices on the host. Note that this also requires the | ||
nomad agent and docker daemon to be configured to allow privileged | ||
containers. | ||
|
||
* `ipc_mode` - (Optional) The IPC mode to be used for the container. The default | ||
is `none` for a private IPC namespace. Other values are `host` for sharing | ||
the host IPC namespace or the name or id of an existing container. Note that | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test the failure conditions as well?