Fix local interface name on OS X #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gregory-m Thanks! And sorry we broke the -dev experience on OSX. Happy to merge this, however can we add a check which won't set the default device to loopback device for any other platform other than linux and darwin? |
|
@diptanu I don't have accuses to any windows machine, and afraid to broke stuff which I even can't test. |
|
@gregory-m No worries! I am going to merge this and make the change myself. |
diptanu
added a commit
that referenced
this pull request
Oct 29, 2015
Fix local interface name on OS X
benbuzbee
pushed a commit
to benbuzbee/nomad
that referenced
this pull request
Jul 21, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #360. Tested on linux and OS X 10.11/10.10.
Not tested on windows.