Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom ports for services and checks when using driver address_mode #3619

Merged
merged 16 commits into from
Dec 11, 2017

Commits on Dec 8, 2017

  1. Allow custom ports for services and checks

    Fixes #3380
    
    Adds address_mode to checks (but no auto) and allows services and checks
    to set literal port numbers when using address_mode=driver.
    
    This allows SDNs, overlays, etc to advertise internal and host addresses
    as well as do checks against either.
    schmichael committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    2556928 View commit details
    Browse the repository at this point in the history
  2. Test Consul from TaskRunner thoroughly

    Rely less on the mockConsulServiceClient because the real
    consul.ServiceClient needs all the testing it can get!
    schmichael committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    74e7d57 View commit details
    Browse the repository at this point in the history
  3. Fix interpolation bug with service/check updates

    Previously if only an interpolated variable used in a service or check
    was changed we interpolated the old and new services and checks with the
    new variable, so nothing appeared to have changed.
    schmichael committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    29e6f7c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f2d4715 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f11360a View commit details
    Browse the repository at this point in the history
  6. Validate port label for host address mode

    Also skip getting an address for script checks which don't use them.
    
    Fixed a weird invalid reserved port in a TaskRunner test helper as well
    as a problem with our mock Alloc/Job. Hopefully the latter doesn't cause
    other tests to fail, but we were referencing an invalid PortLabel and
    just not catching it before.
    schmichael committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    b999358 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fa5faa5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7bf5cec View commit details
    Browse the repository at this point in the history
  9. Hash fields used in task service IDs

    Fixes #3620
    
    Previously we concatenated tags into task service IDs. This could break
    deregistration of tag names that contained double //s like some Fabio
    tags.
    
    This change breaks service ID backward compatibility so on upgrade all
    users services and checks will be removed and re-added with new IDs.
    
    This change has the side effect of including all service fields in the
    ID's hash, so we no longer have to track PortLabel and AddressMode
    changes independently.
    schmichael committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    65bfbe5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    afd5bca View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6f124eb View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4196360 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2a33e10 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e857225 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    63d515d View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2017

  1. Configuration menu
    Copy the full SHA
    b79194f View commit details
    Browse the repository at this point in the history