-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom ports for services and checks when using driver address_mode #3619
Commits on Dec 8, 2017
-
Allow custom ports for services and checks
Fixes #3380 Adds address_mode to checks (but no auto) and allows services and checks to set literal port numbers when using address_mode=driver. This allows SDNs, overlays, etc to advertise internal and host addresses as well as do checks against either.
Configuration menu - View commit details
-
Copy full SHA for 2556928 - Browse repository at this point
Copy the full SHA 2556928View commit details -
Test Consul from TaskRunner thoroughly
Rely less on the mockConsulServiceClient because the real consul.ServiceClient needs all the testing it can get!
Configuration menu - View commit details
-
Copy full SHA for 74e7d57 - Browse repository at this point
Copy the full SHA 74e7d57View commit details -
Fix interpolation bug with service/check updates
Previously if only an interpolated variable used in a service or check was changed we interpolated the old and new services and checks with the new variable, so nothing appeared to have changed.
Configuration menu - View commit details
-
Copy full SHA for 29e6f7c - Browse repository at this point
Copy the full SHA 29e6f7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2d4715 - Browse repository at this point
Copy the full SHA f2d4715View commit details -
Configuration menu - View commit details
-
Copy full SHA for f11360a - Browse repository at this point
Copy the full SHA f11360aView commit details -
Validate port label for host address mode
Also skip getting an address for script checks which don't use them. Fixed a weird invalid reserved port in a TaskRunner test helper as well as a problem with our mock Alloc/Job. Hopefully the latter doesn't cause other tests to fail, but we were referencing an invalid PortLabel and just not catching it before.
Configuration menu - View commit details
-
Copy full SHA for b999358 - Browse repository at this point
Copy the full SHA b999358View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa5faa5 - Browse repository at this point
Copy the full SHA fa5faa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bf5cec - Browse repository at this point
Copy the full SHA 7bf5cecView commit details -
Hash fields used in task service IDs
Fixes #3620 Previously we concatenated tags into task service IDs. This could break deregistration of tag names that contained double //s like some Fabio tags. This change breaks service ID backward compatibility so on upgrade all users services and checks will be removed and re-added with new IDs. This change has the side effect of including all service fields in the ID's hash, so we no longer have to track PortLabel and AddressMode changes independently.
Configuration menu - View commit details
-
Copy full SHA for 65bfbe5 - Browse repository at this point
Copy the full SHA 65bfbe5View commit details -
Configuration menu - View commit details
-
Copy full SHA for afd5bca - Browse repository at this point
Copy the full SHA afd5bcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f124eb - Browse repository at this point
Copy the full SHA 6f124ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4196360 - Browse repository at this point
Copy the full SHA 4196360View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a33e10 - Browse repository at this point
Copy the full SHA 2a33e10View commit details -
Configuration menu - View commit details
-
Copy full SHA for e857225 - Browse repository at this point
Copy the full SHA e857225View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63d515d - Browse repository at this point
Copy the full SHA 63d515dView commit details
Commits on Dec 9, 2017
-
Configuration menu - View commit details
-
Copy full SHA for b79194f - Browse repository at this point
Copy the full SHA b79194fView commit details