Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash fields used in task service IDs #3632

Merged
merged 2 commits into from
Dec 8, 2017
Merged

Hash fields used in task service IDs #3632

merged 2 commits into from
Dec 8, 2017

Commits on Dec 8, 2017

  1. Hash fields used in task service IDs 

    Fixes #3620

Previously we concatenated tags into task service IDs. This could break
deregistration of tag names that contained double //s like some Fabio
tags.

This change breaks service ID backward compatibility so on upgrade all
users services and checks will be removed and re-added with new IDs.

This change has the side effect of including all service fields in the
ID's hash, so we no longer have to track PortLabel and AddressMode
changes independently.
    @schmichael
    schmichael committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    ad88b9b View commit details
    Browse the repository at this point in the history

  2. Move service hash logic to Service.Hash method

    @schmichael
    schmichael committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    9bb2581 View commit details
    Browse the repository at this point in the history