Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed duplicate stats command from output #3704

Merged
merged 2 commits into from
Feb 22, 2018
Merged

removed duplicate stats command from output #3704

merged 2 commits into from
Feb 22, 2018

Conversation

matosf
Copy link
Contributor

@matosf matosf commented Dec 29, 2017

No description provided.

dadgar
dadgar reviewed Jan 3, 2018
View reviewed changes
website/source/docs/operating-a-job/resource-utilization.html.md Outdated
@@ -41,7 +41,6 @@ $ nomad alloc-status -stats 04d9627d
And here is some sample output:

```text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to remove Line 41 and merge the two outputs.

Copy link
Contributor Author

@matosf matosf Jan 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a mix between having the command and the sample output separated and together, so it's your call. e.g.:
https://github.com/hashicorp/nomad/blob/master/website/source/docs/operating-a-job/inspecting-state.html.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind unifying them on that page to combine the command and sample output. Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change so we could get this fix merged in, just because this started to idle.

@angrycub
Removing text between command and output
8a7bb0f 
Per @dadgar's review and @matosf yielding in comments so we can get this correction merged.
@angrycub angrycub merged commit 6a783e9 into hashicorp:master Feb 22, 2018
@angrycub
Copy link
Contributor

@matosf Since you were okay with the combined view based on your comments, I removed the separation between the command and the output. Will get this merged now. :)

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@angrycub angrycub angrycub left review comments

@dadgar dadgar dadgar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matosf @angrycub @dadgar