Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTTP code for permission denied errors #3722

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Fix HTTP code for permission denied errors #3722

merged 1 commit into from
Jan 9, 2018

Commits on Jan 9, 2018

  1. Fix HTTP code for permission denied errors 

    Fixes #3697

The existing code and test case only covered the leader behavior. When
querying against non-leaders the error has an "rpc error: " prefix.

To provide consistency in HTTP error response I also strip the "rpc
error: " prefix for 403 responses as they offer no beneficial additional
information (and in theory disclose a tiny bit of data to unauthorized
users, but it would be a pretty weird bit of data to use in a malicious
way).
    @schmichael
    schmichael committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    ae61f73 View commit details
    Browse the repository at this point in the history