Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxc: cleanup partially configured containers after errors in Start #3773

Merged

Commits on Jan 19, 2018

  1. lxc: cleanup partially configured containers after errors in Start

    If there are any errors in container setup after c.Create() in
    Start(), the container will be left around, with no way to clean it up
    because the handle will not be created or returned from Start.
    
    Added a wrapper that checks for errors and performs appropriate
    cleanup. Returning a cleanup function from a wrapped function instead
    of just doing the cleanup before returning the error helps to ensure
    that future changes that might add or change error exits can't forget
    to consider a cleanup function.
    
    Adds a check to the invalid config test case to check that a container
    created with an invalid config doesn't get left behind.
    
    Signed-off-by: Michael McCracken <mikmccra@cisco.com>
    mikemccracken committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    0e9bae7 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2018

  1. review cleanup

    don't export an internal function, and simplify some code
    
    Signed-off-by: Michael McCracken <mikmccra@cisco.com>
    mikemccracken committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    81f64ee View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. fix speling in log

    Signed-off-by: Michael McCracken <mikmccra@cisco.com>
    mikemccracken committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    2dd31f2 View commit details
    Browse the repository at this point in the history