Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI to use ISO_8601 time format. #3814

Merged
merged 1 commit into from
Jan 30, 2018

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Jan 30, 2018

This change updates the formatTime CLI helper function to return an ISO_8601 time format which will make CLI time usage more consistent and easier. Previously the time format was in US style format which was somewhat confusing to non US users.

This has been tested locally:

./jrasell-nomad job history example
Version     = 0
Stable      = true
Submit Date = 2018-01-30T08:32:29Z
./jrasell-nomad alloc-status f1bab94a |grep 'Started At' 
Started At     = 2018-01-30T08:32:30Z

Closes #3806

This change updates the formatTime CLI helper function to return
an ISO_8601 time format which will make CLI time usage more
consistent and easier. Previosuly the time format was in US style
format which was somewhat confusing to non US users.

Closes hashicorp#3806
@jippi
Copy link
Contributor

jippi commented Jan 30, 2018

looks good! my personal preference is RFC 2822 formatted dates, less dense to grok as a human :)

@danielmotaleite
Copy link

@jippi true, but they are also hard to parse (and sort) by other tools. ISO_8601 is a little harder to read by human, but very consistent and flexible

@danielmotaleite
Copy link

and thanks for the PR @jrasell

@chelseakomlo
Copy link
Contributor

Thanks for this PR, looks good!

@chelseakomlo chelseakomlo merged commit 57dbd6c into hashicorp:master Jan 30, 2018
chelseakomlo added a commit that referenced this pull request Jan 30, 2018
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants