-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the priviledged flag in docker #384
Conversation
Nice! Just a spelling comment: it should be |
// Handle the priviledged flag | ||
priviledged, ok := task.Config["priviledged"] | ||
if !ok || priviledged == "" { | ||
d.logger.Printf("[WARN] driver.docker: priviledged flag not set, defaulting to non-priviledged") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably wouldn't log here since omitting this setting is the normal case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this would be a nice warning in case it was an operator error, since we are defaulting to a value. Also, a monitoring system might be looking at the messages.
@dimfeld thanks for pointing that out, updated. |
@achanda Can we please add some documentation regarding this feature in our docs? @dadgar So based on this PR, I think doing priviledged is a driver option and not something that we allow operators to control? I think on the client side it would be nice to have a flag which an operator could use to not allow priviledged. So a developer can ask for it to be priviledged, but the operator could rule it out. |
@diptanu the PR that was merged does seem to have docs. |
…emantics raft.LeaderCh() always deliver latest transition
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.