-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client driver health checks for Docker #3856
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
1570972
add concept of health checks to fingerprinters and nodes
chelseakomlo a340bad
allow nomad to schedule based on the status of a client driver health…
chelseakomlo 9ec5a93
fix scheduler driver name; create node structs file
chelseakomlo 7c34605
fix up gofmt
chelseakomlo 9dfb5c6
go style; update comments
chelseakomlo 70bebd1
fix up scheduler mocks
chelseakomlo fd25db9
updating comments; locking concurrent node access
chelseakomlo 865b7e0
fix up racy tests
chelseakomlo 240fee4
fix up codereview feedback
chelseakomlo 521fbd4
refresh driver information for non-health checking drivers periodically
chelseakomlo 8a0ed4e
improve tests
chelseakomlo 3ad03d9
notes from walk through
dadgar 8aefd29
Code review feedback
chelseakomlo 115d54c
fix up health check logic comparison; add node events to client drive…
chelseakomlo 8597da0
simplify logic
chelseakomlo 7b2ed01
remove unused function
chelseakomlo 06a306e
improve comments; update watchDriver
chelseakomlo cba0a4d
function rename and re-arrange functions in fingerprint_manager
chelseakomlo 9c14330
fix issue when updating node events
chelseakomlo ffe9292
Only run health check if driver is detected
dadgar b59bea9
Docker driver doesn't return errors but injects into the DriverInfo
dadgar 127b2c6
set driver to unhealthy once if it cannot be detected in periodic check
chelseakomlo eb3a53e
always set initial health status for every driver
chelseakomlo 89ffc96
fix up scheduling test
chelseakomlo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the reason I feel like we skip the health check unless it is detected, otherwise you will mark it as unhealthy and log even if docker just isn't there.