CLI info on delayed rescheduling #3933
Conversation
preetapan
force-pushed
the
f-cli-delayed-rescheduling
branch
from
3dce621
to
aafcc37
Compare
preetapan
force-pushed
the
f-cli-delayed-rescheduling
branch
from
aafcc37
to
530effa
Compare
command/alloc_status.go
Outdated
| @@ -296,6 +303,17 @@ func formatAllocBasicInfo(alloc *api.Allocation, client *api.Client, uuidLength | |||
| return formatKV(basic), nil | |||
| } | |||
|
|
|||
| // lookupEvalTime returns a human | |||
| nextEvalTime := futureEvalTimePretty(alloc.FollowupEvalID, client) | ||
| if nextEvalTime != "" { | ||
| basic = append(basic, | ||
| fmt.Sprintf("Reschedule Eligibility|%s", nextEvalTime)) |
There was a problem hiding this comment.
Don't really like "Reschedule Eligibility". What about "Rescheduling In"?
There was a problem hiding this comment.
"Rescheduling In" won't look right when the alloc has already been rescheduled before you run alloc status. I tried to come up with a phrase that works both directions, so it would read correctly e.g "Reschedule Eligibility: 1hr from now" or "Reschedule Eligibility: 5m ago".
Maybe we can make it just the phrase "Rescheduling"?
There was a problem hiding this comment.
Hmm okay with that context lets keep it as it is. We can try to refine it later.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Show when an allocation is eligible to be rescheduled in the CLI if there's a followup eval id
Builds on top of #3928