Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Docker ENV behavior #407

Merged
merged 4 commits into from
Nov 11, 2015
Merged

Change Docker ENV behavior #407

merged 4 commits into from
Nov 11, 2015

Commits on Nov 10, 2015

  1. Changed behavior for Docker ENV 

    - Docker ENV variables now work the same way in production, dev, and test
- Docker ENV variables are *ignored* if docker.endpoint is present in the Nomad config file
- Remote tests now work correctly
    @cbednarski
    cbednarski committed Nov 10, 2015
    Configuration menu
    Copy the full SHA
    acb8f1d View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2015

  1. Change Docker fingerprinter to INFO and not error when the connection… 

    … to the daemon fails; we simply assume docker isn't there.
    @cbednarski
    cbednarski committed Nov 11, 2015
    Configuration menu
    Copy the full SHA
    4b071f6 View commit details
    Browse the repository at this point in the history

  2. Change dockerIs* to accept *testing.T for logging

    @cbednarski
    cbednarski committed Nov 11, 2015
    Configuration menu
    Copy the full SHA
    fdd21d3 View commit details
    Browse the repository at this point in the history

  3. Added some comments to the test to explain why we're doing stuff this… 

    … way
    @cbednarski
    cbednarski committed Nov 11, 2015
    Configuration menu
    Copy the full SHA
    9fd9e33 View commit details
    Browse the repository at this point in the history