B 2117 windows group process

[ninoles]

A followed up on GH-4153

[ninoles]

BTW, here the job I used for testing:

job "com" {
  datacenters = ["dc1"]
  task "com" {
    driver = "raw_exec"
    config = {
      command = "C:\\WINDOWS\\py.exe"
      args = ["-c", "import subprocess; subprocess.run('nomad logs -f -job com')"]
    }
  }
}

Note that applications like notepad will not work since they don't answer to Ctrl-Break events.

[schmichael]

Thanks @ninoles! There's a couple linter errors that I'll fixup post merge.

[ninoles]

I just try the version you put in #4169 and it works, but not with the job I sent you (I was trying to give you an easier example than what I use for our software). Here a more complete example, that also work with GUI application (notepad here):

job "com" {
   datacenters = ["dc1"]

  task "com" {
    driver = "raw_exec"
    
    config = {
      command = "C:\\WINDOWS\\py.exe"
      args = ["local\\run.py"]
    }
    template {
        data = <<EOH
import subprocess
import time
import signal

proc = subprocess.Popen("notepad")
def kill(sig, frame):
    print("Killing %s with %r" % (proc, sig))
    try:
        proc.terminate()
    except OsError:
        pass
    
signal.signal(signal.SIGBREAK, kill)

try:
    while not proc.poll():
        time.sleep(1)
except KeyboardInterrupt:
    print("Keyboard interrupt received, killing notepad.")
    kill(0, 0)
    proc.wait()
print("Exiting")
EOH

  destination = "local/run.py"
    }
  }
}

[schmichael]

@ninoles I deleted #4169 and merged this PR. Are you saying it doesn't work as expected? Here's an executable built from master 45d0c88

nomad-45d0c88fa-windows_amd64.zip

[ninoles]

No, sorry, the previous job was a slight variation on one I was using internally, in my own setup (with other jobs running, etc.). The one above just work perfectly. My only problems now is how to make nomad ignore the IPv6 address that windows set on their default loopback, but that's another problem.

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.