UI: Stop job button #4189
UI: Stop job button #4189
Conversation
For performing an action that requires confirmation
| @@ -0,0 +1,19 @@ | |||
| {{#if isIdle}} | |||
| <button class="button is-warning is-small is-inline" onclick={{action "promptForConfirmation"}}> | |||
There was a problem hiding this comment.
I think this needs type="button"
There was a problem hiding this comment.
Thanks! Updated it.
| </button> | ||
| {{else if isPendingConfirmation}} | ||
| <span class="confirmation-text">{{confirmationMessage}}</span> | ||
| <button class="button is-dark is-outlined is-small is-inline" onclick={{action (queue |
|
Super nice job! But now I'm wondering if there will be an "start" button to resubmit stopped jobs. :) |
|
@danlsgiga we're being super cautious with introducing write features to the UI. We don't want to conflict with our own philosophy of infrastructure as code, but we also understand that submitting and resubmitting jobs via the web ui would be really nice and convenient. Stay tuned! |
|
Thanks for the quick feedback @DingoEatingFuzz. I understand the fears around deviating from infrastructure as code and I truly endorse this vision. Anyhow, just my .2 on the subject! Keep up the amazing work!! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Introduces a stop button on all job detail pages.
The stop button is a new two-step confirmation button.