-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DriverContext: Add the TaskGroup and the Job name #4196
DriverContext: Add the TaskGroup and the Job name #4196
Conversation
Adding this fields to the DriverContext object, will allow us to pass them to the drivers. An use case for this, will be to emit tagged metrics in the drivers, which contain all relevant information: - Job - TaskGroup - Task - ... Ref: hashicorp#4185
@jvrplmlmn Looking good, check out the test failures: https://travis-ci.org/hashicorp/nomad/jobs/369873910#L952 |
Thanks for the review @dadgar, seems like I missed to push 92cbfd0 Travis keeps failing the build in
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Adding this fields to the DriverContext object, will allow us to pass
them to the drivers.
An use case for this, will be to emit tagged metrics in the drivers,
which contain all relevant information:
For more context, see the following discussion: #4185 (comment)