-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race in StreamFramer and truncation in api/AllocFS.Logs #4234
Merged
Commits on May 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a8e1f35 - Browse repository at this point
Copy the full SHA a8e1f35View commit details -
api: never return EOF from Logs error chan
Closing the frames chan is the only race-free way to signal to receivers that all frames have been sent and no errors have occurred. If EOF is sent on error chan receivers may not receive the last frame (or frames since the chan is buffered) before receiving the error. Closing frames is the idiomatic way of signaling there is no more data to be read from a chan.
Configuration menu - View commit details
-
Copy full SHA for 41f05dc - Browse repository at this point
Copy the full SHA 41f05dcView commit details -
client: reset encoders between uses
According to go/codec's docs, Reset(...) should be called on Decoders/Encoders before reuse: https://godoc.org/github.com/ugorji/go/codec I could find no evidence that *not* calling Reset() caused bugs, but might as well do what the docs say?
Configuration menu - View commit details
-
Copy full SHA for a7c71c1 - Browse repository at this point
Copy the full SHA a7c71c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 564854d - Browse repository at this point
Copy the full SHA 564854dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63dad44 - Browse repository at this point
Copy the full SHA 63dad44View commit details -
Configuration menu - View commit details
-
Copy full SHA for cafcb89 - Browse repository at this point
Copy the full SHA cafcb89View commit details -
Configuration menu - View commit details
-
Copy full SHA for aad596b - Browse repository at this point
Copy the full SHA aad596bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8776cf8 - Browse repository at this point
Copy the full SHA 8776cf8View commit details -
framer: fix race and remove unused error var
In the old code `sending` in the `send()` method shared the Data slice's underlying backing array with its caller. Clearing StreamFrame.Data didn't break the reference from the sent frame to the StreamFramer's data slice.
Configuration menu - View commit details
-
Copy full SHA for 361db26 - Browse repository at this point
Copy the full SHA 361db26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6858c52 - Browse repository at this point
Copy the full SHA 6858c52View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.