Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment improvements #4259

Merged
merged 52 commits into from
May 8, 2018
Merged

deployment improvements #4259

merged 52 commits into from
May 8, 2018

Commits on May 7, 2018

  1. Initial implementation

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    15c3abf View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    1627675 View commit details
    Browse the repository at this point in the history

  3. Progress deadline in deployment state

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    bcaaa10 View commit details
    Browse the repository at this point in the history

  4. Deployment watcher based on deployment having progress deadline

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    2bb9ada View commit details
    Browse the repository at this point in the history

  5. Handle progressed deployments and tests

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    54f9e1b View commit details
    Browse the repository at this point in the history

  6. Pass through timestamp

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    e424a11 View commit details
    Browse the repository at this point in the history

  7. add latest eval back

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    0e2866d View commit details
    Browse the repository at this point in the history

  8. Drop file

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    04a4b1f View commit details
    Browse the repository at this point in the history

  9. Small test fix

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    c3b9a9c View commit details
    Browse the repository at this point in the history

  10. small review feedback fixes

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    1050b89 View commit details
    Browse the repository at this point in the history

  11. rework where time gets set

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    2d6264e View commit details
    Browse the repository at this point in the history

  12. Use UpdateAllocDesiredTransistion instead of UpsertEval but no transi… 

    …stions yet
    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    062f236 View commit details
    Browse the repository at this point in the history

  13. Set Reschedule from deployment watcher

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    91402ed View commit details
    Browse the repository at this point in the history

  14. Only reschedule allowed deployment allocs

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    b1df461 View commit details
    Browse the repository at this point in the history

  15. fix reconcile tests

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    be3e3ea View commit details
    Browse the repository at this point in the history

  16. Test fixes

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    011a084 View commit details
    Browse the repository at this point in the history

  17. Add test where deployment is marked as complete when done even with f… 

    …ailed allocs
    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    b8aa63a View commit details
    Browse the repository at this point in the history

  18. Fix typos

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    f952300 View commit details
    Browse the repository at this point in the history

  19. Fix not enqueuing eval

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    01fcba1 View commit details
    Browse the repository at this point in the history

  20. change default to 10m and docs

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    c240e02 View commit details
    Browse the repository at this point in the history

  21. CLI

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    eb6a99a View commit details
    Browse the repository at this point in the history

  22. Only use DesiredTransition.Reschedule in reconciler when its an activ… 

    …e deployment
    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    32557a1 View commit details
    Browse the repository at this point in the history

  23. Fix deadlock in deployment watcher when deployment starts with no all… 

    …ocations and eventually has failed allocations
    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    aab6149 View commit details
    Browse the repository at this point in the history

  24. better comments and remove commented code

    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    334f5fb View commit details
    Browse the repository at this point in the history

  25. Mark canaries on creation, and unmark on promotion

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    8be599a View commit details
    Browse the repository at this point in the history

  26. Canary tags structs

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    20df5ae View commit details
    Browse the repository at this point in the history

  27. Ensure canaries tags are interpolated

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    5c8238c View commit details
    Browse the repository at this point in the history

  28. remove unnessary merge of DeploymentStatus.Timestamp

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    4bad815 View commit details
    Browse the repository at this point in the history

  29. vendor testify

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    4c45ca8 View commit details
    Browse the repository at this point in the history

  30. Fix tests

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    be30f02 View commit details
    Browse the repository at this point in the history

  31. Allow canary count greater than desired

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    ff7b1be View commit details
    Browse the repository at this point in the history

  32. Test for rescheduling when there are canaries

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    588bf68 View commit details
    Browse the repository at this point in the history

  33. canary reschedule test

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    686cff2 View commit details
    Browse the repository at this point in the history

  34. typo: transistion -> transition

    @schmichael @preetapan
    schmichael authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    1154ccc View commit details
    Browse the repository at this point in the history

  35. consul: support canary tags for services 

    Also refactor Consul ServiceClient to take a struct instead of a massive
set of arguments. Meant updating a lot of code but it should be far
easier to extend in the future as you will only need to update a single
struct instead of every single call site.

Adds an e2e test for canary tags.
    @schmichael @preetapan
    schmichael authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    17c6eb8 View commit details
    Browse the repository at this point in the history

  36. consul: remove services with/without canary tags 

    Guard against Canary being set to false at the same time as an
allocation is being stopped: this could cause RemoveTask to be called
with the wrong Canary value and leaking a service.

Deleting both Canary values is the safest route.
    @schmichael @preetapan
    schmichael authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    435a6bd View commit details
    Browse the repository at this point in the history

  37. Reschedule when we have canaries properly

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    0e1fb91 View commit details
    Browse the repository at this point in the history

  38. Allow healthy canary deployment to skip progress deadline

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    42d3c05 View commit details
    Browse the repository at this point in the history

  39. clarify comment

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    ca588f9 View commit details
    Browse the repository at this point in the history

  40. Make sure that task group has a deployment state before using it

    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    0babfcc View commit details
    Browse the repository at this point in the history

  41. Add test

    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    fc099e5 View commit details
    Browse the repository at this point in the history

  42. consul: change hashed canary bytes

    @schmichael @preetapan
    schmichael authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    64240e4 View commit details
    Browse the repository at this point in the history

  43. Some test fixes to e2e rescheduling tests

    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    83ad99c View commit details
    Browse the repository at this point in the history

  44. More e2e test fixes after changes to rescheduling during deployments

    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    801d147 View commit details
    Browse the repository at this point in the history

  45. Fix the initial progress deadline calculation when the alloc is inpla… 

    …ce updated to be part of a new deployment
    @dadgar @preetapan
    dadgar authored and preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    3701ee0 View commit details
    Browse the repository at this point in the history

  46. Update end to end tests to use shorter progress deadlines

    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    ceafb2b View commit details
    Browse the repository at this point in the history

  47. Fix typo

    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    6b3eb8e View commit details
    Browse the repository at this point in the history

  48. Fix panic in deployment watcher when deployment is not in the state s… 

    …tore due to a gc
    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    809c2a9 View commit details
    Browse the repository at this point in the history

  49. Set modify time for allocs in unit test, and define current time in o… 

    …ne spot
    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    2e393fc View commit details
    Browse the repository at this point in the history

  50. Fix test set up to set ModifyTime for alloc

    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    c317c54 View commit details
    Browse the repository at this point in the history

  51. Fix deadlock in deadline timer logic when progress deadline is passed… 

    … and the deployment is updated.
    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    083541e View commit details
    Browse the repository at this point in the history

  52. newlines in test

    @preetapan
    preetapan committed May 7, 2018
    Configuration menu
    Copy the full SHA
    4bc7db4 View commit details
    Browse the repository at this point in the history