Override 3 sec. WMI timeout in gopsutil #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default timeout is too short for some overburdened or resource constrained machines to complete the WMI query before the context deadline expires. This causes them to be unable to fingerprint the CPU properly.
dadgar
requested changes
May 9, 2018
helper/stats/cpu.go
Outdated
| @@ -28,7 +35,9 @@ func Init() error { | |||
| } | |||
|
|
|||
| var cpuInfo []cpu.InfoStat | |||
| if cpuInfo, err = cpu.Info(); err != nil { | |||
| ctx, _ := context.WithTimeout(context.Background(), cpuInfoTimeout) | |||
|
|
|||
helper/stats/cpu.go
Outdated
|
|
||
| multierror "github.com/hashicorp/go-multierror" | ||
| "github.com/shirou/gopsutil/cpu" | ||
| ) | ||
|
|
||
| const ( | ||
| // We use this constant to override the built in 3 second timeout in gopsutil |
There was a problem hiding this comment.
cpuInfoTimeout is the timeout used when gathering CPU info. This is used to override the default timeout in gopsutil which has a tendency to timeout on Windows.
dadgar
approved these changes
May 9, 2018
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default timeout is too short for some overburdened or resource constrained machines to complete the WMI query before the context deadline expires. This causes them to be unable to fingerprint the CPU properly.