Configurable TLS cipher suites and versions; disallow weak ciphers #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelseakomlo
force-pushed
the
f-tls-remove-weak-standards
branch
from
0bf2f50
to
eb587d6
Compare
chelseakomlo
changed the title
chelseakomlo
changed the title
disallow 3DES and RC4 ciphers add documentation for tls_cipher_suites
chelseakomlo
force-pushed
the
f-tls-remove-weak-standards
branch
from
eb587d6
to
c1b56aa
Compare
chelseakomlo
changed the title
chelseakomlo
changed the title
chelseakomlo
force-pushed
the
f-tls-remove-weak-standards
branch
from
c1b56aa
to
509180e
Compare
dadgar
requested changes
May 9, 2018
nomad/server.go
Outdated
| tlsConf := tlsutil.NewTLSConfiguration(newTLSConfig) | ||
| tlsConf, err := tlsutil.NewTLSConfiguration(newTLSConfig) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
If the error is logged by the caller we should log here
|
|
||
| - `tls_min_version` - Specifies the minimum supported version of TLS. Accepted | ||
| values are "tls10", "tls11", "tls12". Defaults to TLS 1.2. | ||
|
|
There was a problem hiding this comment.
Any reason we aren't also exposing: https://www.consul.io/docs/agent/options.html#tls_prefer_server_cipher_suites
There was a problem hiding this comment.
I wanted to keep the PR minimal to make reviewing simpler, I could add this in a follow up PR.
dadgar
approved these changes
May 10, 2018
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, TLS 1.2 and a subset of safe ciphers are allowed. If operators want to enable TLS 1.0 and unsafe ciphers, this can be done via the agent configuration.