-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go-discover support to Nomad clients #4277
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
1a854c4
add server join info to server and client
chelseakomlo f68a040
add documentation
chelseakomlo 02b89ae
update server_join naming and improve logging
chelseakomlo 0770f03
update documentation for server_join
chelseakomlo b4a0f2c
add further configuration validation for server_join
chelseakomlo 98f2947
cloud auto join documentation
chelseakomlo ef90b44
add to sidebar navidation
chelseakomlo 023cc2c
set retryInterval and other code feedback
chelseakomlo e93dc53
update documentation
chelseakomlo 58a6131
links to server_join docs
chelseakomlo 02a64d0
fix doc links and other improvements
chelseakomlo fa1d2de
RetryInterval should be a time.Duration
chelseakomlo 94cf42e
update config parse test
chelseakomlo 236ac65
add stronger protections for nil pointers in server join merge
chelseakomlo 3d12b3f
ignore default values for retry interval
chelseakomlo 4b20a69
ensure default value of 30s is set for server_join stanza
chelseakomlo 907def0
indentation
dadgar 13f8e91
validation errors
dadgar 2dde49e
Improve validation/defaulting, handle start-join
dadgar 92096d6
Fix website
dadgar 84b4e2c
retry-join flag docs
dadgar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why SetServers changed to return the number of endpoints if its not being used here where its called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to change this so it has the same interface as
Join
for servers, as we both use them as handles toRetryJoiner
.