Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid splitting log line across two files #4282

Merged
merged 4 commits into from
May 21, 2018
Merged

Avoid splitting log line across two files #4282

merged 4 commits into from
May 21, 2018

Commits on May 9, 2018

  1. naming of constants

    @dadgar
    dadgar committed May 9, 2018
    Configuration menu
    Copy the full SHA
    9966194 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2018

  1. Benchmark for rotator 

    BenchmarkRotator/1KB-8            200000              5572 ns/op
BenchmarkRotator/2KB-8            200000              8338 ns/op
BenchmarkRotator/4KB-8            100000             14246 ns/op
BenchmarkRotator/8KB-8             50000             25279 ns/op
BenchmarkRotator/16KB-8            30000             48602 ns/op
BenchmarkRotator/32KB-8            20000             92159 ns/op
BenchmarkRotator/64KB-8            10000            154766 ns/op
BenchmarkRotator/128KB-8            5000            296872 ns/op
BenchmarkRotator/256KB-8            3000            551793 ns/op
    @dadgar
    dadgar committed May 10, 2018
    Configuration menu
    Copy the full SHA
    9918273 View commit details
    Browse the repository at this point in the history

  2. Avoid splitting log line across two files 

    We attempt to avoid splitting a log line between two files by detecting
if we are near the file size limit and scanning for new lines and only
flushing those.

BenchmarkRotator/1KB-8            300000              5613 ns/op
BenchmarkRotator/2KB-8            200000              8384 ns/op
BenchmarkRotator/4KB-8            100000             14604 ns/op
BenchmarkRotator/8KB-8             50000             25002 ns/op
BenchmarkRotator/16KB-8            30000             47572 ns/op
BenchmarkRotator/32KB-8            20000             92080 ns/op
BenchmarkRotator/64KB-8            10000            165883 ns/op
BenchmarkRotator/128KB-8            5000            294405 ns/op
BenchmarkRotator/256KB-8            2000            572374 ns/op
    @dadgar
    dadgar committed May 10, 2018
    Configuration menu
    Copy the full SHA
    8aaf074 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2018

  1. Add new line test

    @dadgar
    dadgar committed May 11, 2018
    Configuration menu
    Copy the full SHA
    80ac8c2 View commit details
    Browse the repository at this point in the history