Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

driver/docker: pull image with digest #4298

Merged
merged 5 commits into from
May 21, 2018
Merged

driver/docker: pull image with digest #4298

merged 5 commits into from
May 21, 2018

Commits on May 14, 2018

  1. driver/docker: pull image with digest 

    GH #4290

Add digest support to the docker driver image config. This commit
factors out some common code to print the repo:tag (dockerImageRef) for
events/logs as well as parsing the image to retreive the repo,tag
(parseDockerImage) so that the results are consistent/sane for both
repo:tag and repo@sha256:... references.

When pulling an image with a digest, the tag is blank and the repo
contains the digest. See:
https://github.com/fsouza/go-dockerclient/blob/master/image_test.go#L471
    @justenwalker
    justenwalker committed May 14, 2018
    Configuration menu
    Copy the full SHA
    e77d8a5 View commit details
    Browse the repository at this point in the history

  2. driver/docker: cleanup parseDockerImage

    @justenwalker
    justenwalker committed May 14, 2018
    Configuration menu
    Copy the full SHA
    ce63b79 View commit details
    Browse the repository at this point in the history

  3. driver/docker: fix TestDockerDriver_ForcePull_RepoDigest

    @justenwalker
    justenwalker committed May 14, 2018
    Configuration menu
    Copy the full SHA
    4492333 View commit details
    Browse the repository at this point in the history

  4. driver/docker: fix up TestParseDockerImage

    @justenwalker
    justenwalker committed May 14, 2018
    Configuration menu
    Copy the full SHA
    f4670f6 View commit details
    Browse the repository at this point in the history

  5. driver/docker: add test for dockerImageRef

    @justenwalker
    justenwalker committed May 14, 2018
    Configuration menu
    Copy the full SHA
    ba2d957 View commit details
    Browse the repository at this point in the history