-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tls PreferServerCipherSuites #4338
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,6 +67,9 @@ the [Agent's Gossip and RPC Encryption](/docs/agent/encryption.html). | |
- `tls_min_version` - Specifies the minimum supported version of TLS. Accepted | ||
values are "tls10", "tls11", "tls12". Defaults to TLS 1.2. | ||
|
||
- tls_prefer_server_cipher_suites - This option will cause Nomad to prefer the | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Put it in code blocks and always start the docs with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add the default value to this, tls_min_version and tls_cipher_suites. For the cipher_suites use: https://www.nomadproject.io/docs/agent/configuration/client.html#servers There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tls_min_version and tls_cipher_suites both specify defaults, but if there is a clearer way to indicate this let me know. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See how all other fields use the common format of specifying defaults after the parameter name: https://github.com/hashicorp/nomad/pull/4338/files#diff-3b31a52d9f28cef5fa96fb6f8b149907R57 |
||
server's ciphersuite over the client ciphersuites. | ||
|
||
- `verify_https_client` `(bool: false)` - Specifies agents should require | ||
client certificates for all incoming HTTPS requests. The client certificates | ||
must be signed by the same CA as Nomad. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to be next to cipher suites