De-nest docker registry auth and reformat related doc

[carlosdp]

I'm not sure what happened here, but it looks like the Docker registry authentication parameters added in #390 aren't being decoded?

De-nesting the parameters seems to fix it. I'm guessing it's something to do with how mapstructure decodes the driver config struct.

I also removed the periods (.) from the related keys as they are awkward to type in HCL files as they have to be wrapped in quotes, and re-formatted the related docs a bit so that it's more clear the keys are at the same "level" as the rest of the driver config parameters. I can revert these though if there's a good reason they should be the way they were before.

[cbednarski]

Thanks for the PR. I'm not sure the implementation here was completed. I think it should look something like below and thus not need dots or underscores, but this mapstructure needs to be pinned to the auth key. Labels are also expressed this way now but since they're arbitrary k/v pairs there's no mapstructure associated with them.

config {
  auth {
    username = "username"
    password = "password"
  }
}

[cbednarski]

This causes credential leakage.

[carlosdp]

Yep, good catch (debugging cruft)

[carlosdp]

I agree, that's how I originally thought it worked. I'll make that change.

[carlosdp]

Updated to take keys under auth object.

[cbednarski]

Looks good! Thanks for following up. Would you be able to add a test for this?

[carlosdp]

Yep, was just thinking that this morning. Will add.

[cbednarski]

@carlosdp I'm going to merge this now because we want to avoid a BC break in config syntax in the 0.2 release. If you're still working on the tests please open a follow-up PR. Otherwise I will get around to this later. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.