Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Refactor breadcrumbs #4458

Merged
merged 16 commits into from
Jul 10, 2018
Merged

UI: Refactor breadcrumbs #4458

merged 16 commits into from
Jul 10, 2018

Commits on Jul 6, 2018

  1. New breadcrumb service and component for describing breadcrumbs in ro… 

    …utes

Works by segmenting the currentRouteName from the router service
and walking over each route in the current hierarchy to collect crumbs.
    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    dd6f126 View commit details
    Browse the repository at this point in the history

  2. Apply new breadcrumbs pattern to servers and clients

    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    e513f92 View commit details
    Browse the repository at this point in the history

  3. Support promise proxies as breadcrumbs

    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    e38cff6 View commit details
    Browse the repository at this point in the history

  4. Recompute breadcrumbs when a model changes but the current route does… 

    … not

Example: parent job to child job navigation
    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    da61ab2 View commit details
    Browse the repository at this point in the history

  5. Add breadcrumbs to jobs routes

    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    0e3701d View commit details
    Browse the repository at this point in the history

  6. Use the new breadcrumbs pattern on the clients loading page

    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    771ad07 View commit details
    Browse the repository at this point in the history

  7. Use the new breadcrumbs pattern in all job templates

    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    6578b36 View commit details
    Browse the repository at this point in the history

  8. Support namespaces in job breadcrumbs

    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    9988371 View commit details
    Browse the repository at this point in the history

  9. Apply new breadcrumbs pattern to task groups

    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    7e2dbd8 View commit details
    Browse the repository at this point in the history

  10. Use the new breadcrumbs pattern for allocations

    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    8064cf5 View commit details
    Browse the repository at this point in the history

  11. Use the new breadcrumb pattern on tasks

    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    9b68f15 View commit details
    Browse the repository at this point in the history

  12. Remove all references to breadcrumbs outside of routes

    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    0f90e06 View commit details
    Browse the repository at this point in the history

  13. Update tests to match new test selectors

    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    954d128 View commit details
    Browse the repository at this point in the history

  14. Move the global-header up the route hierarchy 

    Now that breadcrumbs are a zero config component, the corresponding
template can be moved up to parent routes.
    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    8a3093f View commit details
    Browse the repository at this point in the history

  15. Unit tests for the breadcrumbs service

    @DingoEatingFuzz
    DingoEatingFuzz committed Jul 6, 2018
    Configuration menu