spread stanza api and parsing #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jippi
reviewed
Jul 23, 2018
nomad/structs/structs.go
Outdated
| if len(s.SpreadTarget) == 0 { | ||
| // TODO(preetha): This should go away if we can assume even spread if there are no targets | ||
| // In that case, the target percentages should be calculated at schedule time | ||
| mErr.Errors = append(mErr.Errors, errors.New("Atleast one spread target value must be specified")) |
There was a problem hiding this comment.
would be nice to assume even spread
preetapan
force-pushed
the
f-spread-api-parsing
branch
from
d253bab
to
6ec542a
Compare
preetapan
force-pushed
the
f-affinities-spread
branch
from
8ec5642
to
ed4cb93
Compare
preetapan
force-pushed
the
f-spread-api-parsing
branch
from
6ec542a
to
965ce06
Compare
dadgar
approved these changes
Jul 24, 2018
preetapan
force-pushed
the
f-spread-api-parsing
branch
2 times, most recently
from
e67aa05
to
b9839d6
Compare
…red count in each target. Added this as a new step in the stack and some unit tests
instead, calculate them based on delta between current and minimum value
Also addressed other small code review comments
preetapan
force-pushed
the
f-affinities-spread
branch
from
ed4cb93
to
bb26ba3
Compare
preetapan
force-pushed
the
f-spread-api-parsing
branch
from
b9839d6
to
edbc43d
Compare
Merged
Merged
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of PR #4527, API and parsing layer for spread stanza