Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Region Switcher #4572

Merged
merged 32 commits into from
Aug 13, 2018
Merged

UI: Region Switcher #4572

merged 32 commits into from
Aug 13, 2018

Commits on Aug 10, 2018

  1. Configuration menu
    Copy the full SHA
    ccae1fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc1a031 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    27308a8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    200b3c3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2e26a61 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    840069d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8d36ac8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8c3e5b2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    47210b3 View commit details
    Browse the repository at this point in the history
  10. Move the region switcher out of the secondary nav and into the gutter…

    … when the gutter is collapsed
    DingoEatingFuzz committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    3f26214 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    610db7c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    95fcbda View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    d77504c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    134ab34 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7e6f02d View commit details
    Browse the repository at this point in the history
  16. Clear up the data flow for namespaces

    This is incredibly tricky with query params, since there is a bundle of
    timing issues, lifecycle issues, missing features, and all around
    gotchas with query params.
    
    This solution has no observers and no instances of the system service
    being set from the jobs controller.
    
    The upside to this is no observers, much easier to follow logic, no more
    dependent key chain reactions.
    DingoEatingFuzz committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    4715696 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    a5da73d View commit details
    Browse the repository at this point in the history
  18. Sidestep a transpilation bug.

    Default params don't make it into arguments which were being splatted
    into the call to super.
    DingoEatingFuzz committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    61bdc3b View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    4473bb9 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    c5439df View commit details
    Browse the repository at this point in the history
  21. Get the server's region (aka default region) from the API

    The default region shouldn't be used as a qp since no qp means the same
    thing.
    DingoEatingFuzz committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    d690709 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    ae0bf90 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    fe315fe View commit details
    Browse the repository at this point in the history
  24. Handle errors when getting regions or the default regions

    This protects against volatility in the server and, more commonly, ACLs
    returning forbidden responses.
    DingoEatingFuzz committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    822d998 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    b767a87 View commit details
    Browse the repository at this point in the history
  26. Simplify the control flow around changing namespaces and regions

    The UI will no longer try to redirect to the appropriate namespace or
    region if one is found in localStorage. Instead, it will assume that
    the lack of query param means the default namespaces or region is
    desired.
    DingoEatingFuzz committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    362aff0 View commit details
    Browse the repository at this point in the history
  27. Specify the request type for token self

    Without this, the data (query params) get json stringified
    DingoEatingFuzz committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    c55df8f View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    dbc18c9 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    ae464a0 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    95e8259 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2018

  1. Use the model hook and setupController hook instead of afterModel

    This is a more idiomatic way to handle the QP resetting in the
    application controller.
    DingoEatingFuzz committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    3192267 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a61ad7a View commit details
    Browse the repository at this point in the history