-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Region Switcher #4572
UI: Region Switcher #4572
Commits on Aug 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for ccae1fb - Browse repository at this point
Copy the full SHA ccae1fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc1a031 - Browse repository at this point
Copy the full SHA dc1a031View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27308a8 - Browse repository at this point
Copy the full SHA 27308a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 200b3c3 - Browse repository at this point
Copy the full SHA 200b3c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e26a61 - Browse repository at this point
Copy the full SHA 2e26a61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 840069d - Browse repository at this point
Copy the full SHA 840069dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d36ac8 - Browse repository at this point
Copy the full SHA 8d36ac8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c3e5b2 - Browse repository at this point
Copy the full SHA 8c3e5b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47210b3 - Browse repository at this point
Copy the full SHA 47210b3View commit details -
Move the region switcher out of the secondary nav and into the gutter…
… when the gutter is collapsed
Configuration menu - View commit details
-
Copy full SHA for 3f26214 - Browse repository at this point
Copy the full SHA 3f26214View commit details -
Configuration menu - View commit details
-
Copy full SHA for 610db7c - Browse repository at this point
Copy the full SHA 610db7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95fcbda - Browse repository at this point
Copy the full SHA 95fcbdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d77504c - Browse repository at this point
Copy the full SHA d77504cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 134ab34 - Browse repository at this point
Copy the full SHA 134ab34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e6f02d - Browse repository at this point
Copy the full SHA 7e6f02dView commit details -
Clear up the data flow for namespaces
This is incredibly tricky with query params, since there is a bundle of timing issues, lifecycle issues, missing features, and all around gotchas with query params. This solution has no observers and no instances of the system service being set from the jobs controller. The upside to this is no observers, much easier to follow logic, no more dependent key chain reactions.
Configuration menu - View commit details
-
Copy full SHA for 4715696 - Browse repository at this point
Copy the full SHA 4715696View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5da73d - Browse repository at this point
Copy the full SHA a5da73dView commit details -
Default params don't make it into arguments which were being splatted into the call to super.
Configuration menu - View commit details
-
Copy full SHA for 61bdc3b - Browse repository at this point
Copy the full SHA 61bdc3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4473bb9 - Browse repository at this point
Copy the full SHA 4473bb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5439df - Browse repository at this point
Copy the full SHA c5439dfView commit details -
Get the server's region (aka default region) from the API
The default region shouldn't be used as a qp since no qp means the same thing.
Configuration menu - View commit details
-
Copy full SHA for d690709 - Browse repository at this point
Copy the full SHA d690709View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae0bf90 - Browse repository at this point
Copy the full SHA ae0bf90View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe315fe - Browse repository at this point
Copy the full SHA fe315feView commit details -
Handle errors when getting regions or the default regions
This protects against volatility in the server and, more commonly, ACLs returning forbidden responses.
Configuration menu - View commit details
-
Copy full SHA for 822d998 - Browse repository at this point
Copy the full SHA 822d998View commit details -
Configuration menu - View commit details
-
Copy full SHA for b767a87 - Browse repository at this point
Copy the full SHA b767a87View commit details -
Simplify the control flow around changing namespaces and regions
The UI will no longer try to redirect to the appropriate namespace or region if one is found in localStorage. Instead, it will assume that the lack of query param means the default namespaces or region is desired.
Configuration menu - View commit details
-
Copy full SHA for 362aff0 - Browse repository at this point
Copy the full SHA 362aff0View commit details -
Specify the request type for token self
Without this, the data (query params) get json stringified
Configuration menu - View commit details
-
Copy full SHA for c55df8f - Browse repository at this point
Copy the full SHA c55df8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbc18c9 - Browse repository at this point
Copy the full SHA dbc18c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae464a0 - Browse repository at this point
Copy the full SHA ae464a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95e8259 - Browse repository at this point
Copy the full SHA 95e8259View commit details
Commits on Aug 13, 2018
-
Use the model hook and setupController hook instead of afterModel
This is a more idiomatic way to handle the QP resetting in the application controller.
Configuration menu - View commit details
-
Copy full SHA for 3192267 - Browse repository at this point
Copy the full SHA 3192267View commit details -
Configuration menu - View commit details
-
Copy full SHA for a61ad7a - Browse repository at this point
Copy the full SHA a61ad7aView commit details