Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close multiplexer when context is cancelled #4573

Merged
merged 1 commit into from
Aug 14, 2018

Commits on Aug 13, 2018

  1. Close multiplexer when context is cancelled

    Multiplexer continues to create rpc connections even when
    the context which is passed to the underlying rpc connections
    is cancelled by the server.
    
    This was causing hashicorp#4413 - when a SIGHUP causes everything to reload,
    it uses context to cancel the underlying http/rpc connections
    so that they may come up with the new configuration.
    The multiplexer was not being cancelled properly so it would
    continue to create rpc connections and constantly fail,
    causing communication issues with other nomad agents.
    
    Fixes hashicorp#4413
    Xopherus committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    3f24197 View commit details
    Browse the repository at this point in the history