Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: accept CA PEM files with extra whitespace #4613

Merged
merged 1 commit into from
Sep 7, 2018
Merged

config: accept CA PEM files with extra whitespace #4613

merged 1 commit into from
Sep 7, 2018

Commits on Sep 6, 2018

  1. config: accept CA PEM files with extra whitespace 

    Previously we did a validation pass over CA PEM files before calling
Go's CertPool.AppendCertsFromPEM to provide more detailed error messages
than the stdlib provides.

Unfortunately our validation was overly strict and rejected valid CA
files. This is actually the reason the stdlib PEM parser doesn't return
meaningful errors: PEM files are extremely permissive and it's difficult
to tell the difference between invalid data and valid metadata.

This PR removes our custom validation as it would reject valid data and
the extra error messages were not useful in diagnosing the error
encountered.
    @schmichael
    schmichael committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    556adad View commit details
    Browse the repository at this point in the history