Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn that data_dir can't be in the jail #4618

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Warn that data_dir can't be in the jail #4618

merged 1 commit into from
Feb 19, 2019

Conversation

angrycub
Copy link
Contributor

Added this to help users avoid #2522

nickethier
nickethier approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@nickethier nickethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I wonder if we should do a runtime check to see if the data-dir is prefixed with one of the chrooted paths?

@notnoop notnoop merged commit 427ab71 into master Feb 19, 2019
@notnoop notnoop deleted the d-warn-datadir-in-jail branch February 19, 2019 01:40
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nickethier nickethier nickethier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angrycub @nickethier @notnoop