Update runc/libcontainer and friends #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dadgar
approved these changes
Sep 10, 2018
nickethier
force-pushed
the
f-vendor-libcontainer
branch
from
b7bb06f
to
27556d9
Compare
schmichael
approved these changes
Sep 14, 2018
| @@ -2,113 +2,131 @@ | |||
| "comment": "", | |||
| "ignore": "test", | |||
| "package": [ | |||
| {"path":"context","revision":""}, | |||
There was a problem hiding this comment.
Well that's exciting. Good catch.
|
Actually just noticed the test failures look pretty real. Are those known and going to be fixed up post-merge? |
|
Yeah this is fixed by the new executor, but I suppose it raises the question if it should go into master |
|
@nickethier If it breaks master, keep it in the feature branch. |
nickethier
force-pushed
the
r-clientv2
branch
from
ba95b44
to
2b03e8b
Compare
dadgar
pushed a commit
that referenced
this pull request
Sep 16, 2018
* vendor: bump libcontainer and docker to remove Sirupsen imports * vendor: fix bad vendoring of archive package * vendor: fix api changes to cgroups in executor * vendor: fix docker api changes * vendor: update github.com/Azure/go-ansiterm to use non capitalized logrus import
dadgar
pushed a commit
that referenced
this pull request
Sep 17, 2018
* vendor: bump libcontainer and docker to remove Sirupsen imports * vendor: fix bad vendoring of archive package * vendor: fix api changes to cgroups in executor * vendor: fix docker api changes * vendor: update github.com/Azure/go-ansiterm to use non capitalized logrus import
dadgar
pushed a commit
that referenced
this pull request
Sep 18, 2018
* vendor: bump libcontainer and docker to remove Sirupsen imports * vendor: fix bad vendoring of archive package * vendor: fix api changes to cgroups in executor * vendor: fix docker api changes * vendor: update github.com/Azure/go-ansiterm to use non capitalized logrus import
schmichael
pushed a commit
that referenced
this pull request
Oct 16, 2018
* vendor: bump libcontainer and docker to remove Sirupsen imports * vendor: fix bad vendoring of archive package * vendor: fix api changes to cgroups in executor * vendor: fix docker api changes * vendor: update github.com/Azure/go-ansiterm to use non capitalized logrus import
schmichael
pushed a commit
that referenced
this pull request
Oct 16, 2018
* vendor: bump libcontainer and docker to remove Sirupsen imports * vendor: fix bad vendoring of archive package * vendor: fix api changes to cgroups in executor * vendor: fix docker api changes * vendor: update github.com/Azure/go-ansiterm to use non capitalized logrus import
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in updated deps from libcontainer, this caused some breaking changes with docker so docker was also updated to the latest stable release. Additionally logrus was upgraded to use the lowercase spelling of the repo.