Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip check for advertise address for http and rpc in client mode. #4678

Closed
wants to merge 0 commits into from
Closed

Conversation

tantra35
Copy link
Contributor

This is may be useful when we set bind addr to 127.0.0.1(localhost) when nomad in client mode, and consul.auto_advertise was set into false

Due new nomad rpc communication, its not necessary bind to 0.0.0.0 in client mode, and when nomad agent doiens't advertise him by consul, so we can set bind addr to localhost, but without this patch nomad doesn't start with error:

Failed to parse HTTP advertise address (, 127.0.0.1, 4646, false): Defaulting advertise to localhost is unsafe, please set advertise manually

But this is wrong

@dadgar
Copy link
Contributor

dadgar commented Sep 17, 2018

@tantra35 Hey can you split these into two separate PRs.

@tantra35 tantra35 closed this Sep 18, 2018
@tantra35
Copy link
Contributor Author

@dadgar sorry we didn't figure it out right away.

We create new pull requests
#4688
#4687

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants