Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Denormalize jobs in plan and ignore resources of terminal allocs #4713

Merged
merged 3 commits into from
Sep 24, 2018
Merged

Denormalize jobs in plan and ignore resources of terminal allocs #4713

merged 3 commits into from
Sep 24, 2018

Commits on Sep 24, 2018

  1. Denormalize jobs in plan and ignore resources of terminal allocs 

    Denormalize jobs in AppendAllocs:
AppendAlloc was originally only ever called for inplace upgrades and new
allocations. Both these code paths would remove the job from the
allocation. Now we use this to also add fields such as FollowupEvalID
which did not normalize the job. This is only a performance enhancement.

Ignore terminal allocs:
Failed allocations are annotated with the followup Eval ID when one is
created to replace the failed allocation. However, in the plan applier,
when we check if allocations fit, these terminal allocations were not
filtered. This could result in the plan being rejected if the node would
be overcommited if the terminal allocations resources were considered.
    @dadgar
    dadgar committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    82889c4 View commit details
    Browse the repository at this point in the history

  2. Better comment on snapshotindex

    @dadgar
    dadgar committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    06920ee View commit details
    Browse the repository at this point in the history

  3. test allocs fit

    @dadgar
    dadgar committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    4c40d62 View commit details
    Browse the repository at this point in the history