Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Add some simple accessibility labels for line charts #4718

Merged
merged 5 commits into from
Oct 17, 2018
Merged

UI: Add some simple accessibility labels for line charts #4718

merged 5 commits into from
Oct 17, 2018

Commits on Sep 27, 2018

  1. Add a longForm option to format-duration

    @DingoEatingFuzz
    DingoEatingFuzz committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    9a6d2be View commit details
    Browse the repository at this point in the history

  2. Add a11y features to the line-chart component 

    - Treat it as an image
- Add a title and a description
- Hide the axes, just in case
    @DingoEatingFuzz
    DingoEatingFuzz committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    d83d231 View commit details
    Browse the repository at this point in the history

  3. Override the a11y title and description for the stats time series chart 

    Since this is a use case specific chart, we can use use case specific
language in our labels.
    @DingoEatingFuzz
    DingoEatingFuzz committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    6d4d520 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. Be consistent with "time series" instead of "time-series"

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    3517c7c View commit details
    Browse the repository at this point in the history

  2. Add more documentation to the format-duration util

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    35b933a View commit details
    Browse the repository at this point in the history