-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Series of scheduler fixes / debugging enhancements #4720
Conversation
Fixes three issues: 1. Retrieving the latest evaluation index was not properly selecting the greatest index. This would undermine checks we had to reduce the number of evaluations created when the latest eval index was greater than any alloc change 2. Fix an issue where the blocking query code was using the incorrect index such that the index was higher than necassary. 3. Special case handling of blocked evaluation since the create/snapshot index is no particularly useful since they can be reblocked.
Denormalize jobs in AppendAllocs: AppendAlloc was originally only ever called for inplace upgrades and new allocations. Both these code paths would remove the job from the allocation. Now we use this to also add fields such as FollowupEvalID which did not normalize the job. This is only a performance enhancement. Ignore terminal allocs: Failed allocations are annotated with the followup Eval ID when one is created to replace the failed allocation. However, in the plan applier, when we check if allocations fit, these terminal allocations were not filtered. This could result in the plan being rejected if the node would be overcommited if the terminal allocations resources were considered.
Give blocked evals a unique triggerby reason to make debugging a chain of evaluations easier.
Fix deployment watcher index usage
Unique TriggerBy for blocked evals
Add a missing eval trigger reason
Can you outline what the changes actually fixes? :) |
@jippi You can look at the individual PRs for context. This branch was just a place to merge individual fixes. The changelog also has documentation of the fixes: https://github.com/hashicorp/nomad/blob/release-086/CHANGELOG.md#086-september-24-2018 |
Series of scheduler fixes / debugging enhancements
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
See the following PRs for more information: